Remove request content from UI messages #8696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
Contributor
Code Review SummaryI've completed the review of this PR. The changes cleanly remove the Changes Reviewed✅ Backend (Task.ts): Removed AnalysisThe implementation is clean and consistent across all layers:
ResultNo issues found. The changes are well-implemented and achieve the stated goal of removing request content from UI messages without introducing bugs or breaking existing functionality. Status: ✅ Approved - Ready to merge |
hannesrudolph
added
the
Issue/PR - Triage
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
cte
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying out another approach to #8692 - not sure any of this content is actually very important to include in the UI messages, especially if it causes gray screens?
Before:
After:
Fixes #8690
Fixes #5601
Fixes #8594
Important
Remove request content from
api_req_startedandapi_req_finishedmessages to prevent UI issues, updatingTask.ts,Task.spec.ts, andChatRow.tsxaccordingly.api_req_startedandapi_req_finishedmessages inTask.tsto prevent UI issues.ChatRow.tsxto handle absence of request content in UI rendering.Task.spec.tsto remove references to request content in tests forapi_req_startedandapi_req_finishedmessages.This description was created by
for 3afc7da. You can customize this summary. It will automatically update as commits are pushed.